Skip to content

updated footer to get year based on current date #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2019
Merged

updated footer to get year based on current date #1696

merged 1 commit into from
Feb 17, 2019

Conversation

saranshkataria
Copy link
Member

When I was merging the recent PR for updating year, I realized that it would be better to generate it using javascript instead of changing it manually every year

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit cbe648e

https://deploy-preview-1696--reactjs.netlify.com

Copy link
Member

@tesseralis tesseralis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I don't see a problem with it but I wonder if there's some weird legal reason it has to be updated by hand, haha.

@tesseralis tesseralis merged commit 5fdb6a2 into reactjs:master Feb 17, 2019
@saranshkataria
Copy link
Member Author

haha, none of the lawyers need to know that we are automating things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants