Fix a few typos and add a few suggestions #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 64d4936 |
yangshun
reviewed
Oct 16, 2017
| @@ -67,7 +67,7 @@ Jay Garcia spent a lot of time during the beta working on a NES music player wit | |||
|
|
|||
| ## React Native with Babel and webpack | |||
|
|
|||
| React Native ships with a custom packager and custom ES6 transforms instead of using what the open source community settled on such as webpack and Babel. The main reason for this is performance – we couldn't get those tools to have sub-second reload time on a large codebase. | |||
| React Native ships with a custom packager and custom ES6 transforms instead of using what the open source community settled on such as [webpack] (https://webpack.js.org/) and [Babel](http://babeljs.io/). The main reason for this is performance – we couldn't get those tools to have sub-second reload time on a large codebase. | |||
There was a problem hiding this comment.
There shouldn't be a space after [webpack] because most Markdown engines will not treat this as a link (See the preview for this file).
content/docs/installation.md
Outdated
| @@ -40,9 +40,9 @@ cd my-app | |||
| npm start | |||
| ``` | |||
|
|
|||
| Create React App doesn't handle backend logic or databases; it just creates a frontend build pipeline, so you can use it with any backend you want. It uses build tools like Babel and webpack under the hood, but works with zero configuration. | |||
| `Create React App` doesn't handle backend logic or databases; it just creates a frontend build pipeline, so you can use it with any backend you want. It uses build tools like [Babel] (http://babeljs.io/) and [webpack] (http://babeljs.io/) under the hood, but works with zero configuration. | |||
There was a problem hiding this comment.
The webpack link is incorrect. Will be good to reomve the spaces as well as mentioned earlier.
There was a problem hiding this comment.
I don't think Create React App should be formatted as code. "Create React App" is a title, vs create-react-app which is the tool.
Update webpack link, remove spaces, unhighlight `Create React App`
|
@yangshun Thanks for your review. I pushed the updates. Please take a look. |
yangshun
reviewed
Oct 16, 2017
| @@ -67,7 +67,7 @@ Jay Garcia spent a lot of time during the beta working on a NES music player wit | |||
|
|
|||
| ## React Native with Babel and webpack | |||
|
|
|||
| React Native ships with a custom packager and custom ES6 transforms instead of using what the open source community settled on such as webpack and Babel. The main reason for this is performance – we couldn't get those tools to have sub-second reload time on a large codebase. | |||
| React Native ships with a custom packager and custom ES6 transforms instead of using what the open source community settled on such as [webpack](https://webpack.js.org/) and [Babel](http://babeljs.io/). The main reason for this is performance – we couldn't get those tools to have sub-second reload time on a large codebase. | |||
There was a problem hiding this comment.
Sorry, just a couple more nits which I should have caught earlier. Would be good to use https://babeljs.io/ instead of http://babeljs.io/ (they should probably do a redirect)
content/docs/installation.md
Outdated
|
|
||
| When you're ready to deploy to production, running `npm run build` will create an optimized build of your app in the `build` folder. You can learn more about Create React App [from its README](https://github.com/facebookincubator/create-react-app#create-react-app-) and the [User Guide](https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#table-of-contents). | ||
| When you're ready to deploy to production, running `npm run build` will create an optimized build of your app in the `build` folder. You can learn more about `Create React App` [from its README](https://github.com/facebookincubator/create-react-app#create-react-app-) and the [User Guide](https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#table-of-contents). |
There was a problem hiding this comment.
Create React App shouldn't be in quotes
|
@yangshun I made these new updates as well. Can you please take a look? Thanks in advance. |
bvaughn
approved these changes
Oct 16, 2017
| @@ -66,7 +66,7 @@ See the [React.Component API Reference](/docs/react-component.html) for a list o | |||
|
|
|||
| ### `React.PureComponent` | |||
|
|
|||
| `React.PureComponent` is exactly like [`React.Component`](#reactcomponent) but implements [`shouldComponentUpdate()`](/docs/react-component.html#shouldcomponentupdate) with a shallow prop and state comparison. | |||
| `React.PureComponent` is exactly like [`React.Component`](#reactcomponent), but implements [`shouldComponentUpdate()`](/docs/react-component.html#shouldcomponentupdate) with a shallow prop and state comparison. | |||
There was a problem hiding this comment.
nit: I don't think this comma is necessary?
implements
shouldComponentUpdate()with a shallow prop and state comparison.
This ^ isn't an independent clause. Maybe it's an appositive?
There was a problem hiding this comment.
What am I doing with my life... 🤡
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
Sync with reactjs.org @ c0f4b34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request includes a few typos (like missing colons and commas), and also hyperlinks Babel and webpack.