Mention ad blockers when Babel is not defined #158
Conversation
| @@ -177,6 +177,7 @@ class CodeEditor extends Component { | |||
| padding: 10, | |||
| }}> | |||
| {error.message} | |||
| {!window.Babel && ' (try checking your ad blocker if you have one).'} | |||
There was a problem hiding this comment.
Should it also ask the user to whitelist the website?
|
Deploy preview ready! Built with commit 26c975d |
There was a problem hiding this comment.
I'm not sure this new wording is actionable enough as is. (I worry that a user wouldn't know to whitelist reactjs.org if they want the live code examples to work.) How do you feel about wording more like:
Babel could not be loaded. This can be caused by ad blockers. If you're using an ad blocker, consider adding reactjs.org to the whitelist so the live code examples will work.
I also wonder if it might be a little cleaner to detect this error condition in _updateState (within the try/catch) and set a flag in state to show the special Babel message (rather than having the inline conditional in render).
|
Sure, so the special message should be shown instead of "Babel is not defined", right? |
|
Yeah, that's what I was thinking- we could check this state-flag and render some custom text instead of |
* Translated Community/Courses; * Added ReactJS Ninja in Paid Courses.
Closes #3.