Skip to content

Small typo fix #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Small typo fix #1317

merged 1 commit into from
Feb 22, 2019

Conversation

tusharkhatiwada
Copy link
Contributor

No description provided.

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit a531a0f

https://deploy-preview-1317--reactjs.netlify.com

@lex111 lex111 merged commit d615c5b into reactjs:master Feb 22, 2019
@lex111
Copy link
Member

lex111 commented Feb 22, 2019

@tusharkhatiwada sorry for the long delay, thanks!

@@ -109,7 +109,7 @@ There are a few more heuristics, and they might change over time as we fine-tune

### How do lifecycle methods correspond to Hooks?

* `constructor`: Function components don't need a constructor. You can initialize the state in the [`useState`](/docs/hooks-reference.html#usestate) call. If computing it is expensive, you can pass a function to `useState`.
Copy link
Member

@tesseralis tesseralis Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually a typo. It reads as "If computing it (the state) is expensive, you can pass a function to useState."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit the wording is confusing, so perhaps we could change this instead to:

if computing the state is expensive, you can pass a function to useState.

@gaearon gaearon mentioned this pull request Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants