Skip to content

Add CircleCI config #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2017
Merged

Add CircleCI config #131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd35a73
Add circle ci config
jxom Oct 11, 2017
76d431d
Add caching to circle config
jxom Oct 11, 2017
086322a
Update circle config
jxom Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
version: 2
jobs:
build:
docker:
- image: circleci/node:latest
steps:
- checkout
- restore_cache:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a step to explicitly install Yarn if it's not already installed? The React repo's circle.yml file has this:

  pre:
    # This is equivalent to $TRAVIS_COMMIT_RANGE
    - echo $CIRCLE_COMPARE_URL | cut -d/ -f7
    # install yarn if it's not already installed
    - |
      if [[ ! -e ~/.yarn/bin/yarn || $(yarn --version) != "${YARN_VERSION}" ]]; then
        curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version $YARN_VERSION
      fi

Maybe this isn't necessary with the 2.0 API. The 1.0 API docs have a section about how to enable Yarn which the 2.0 docs don't have. Maybe it just works out of the box now? 😁 Let's try and see!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it’s already installed on v2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems like that's the case.

keys:
- dependencies-{{ checksum "package.json" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should checksum "yarn.lock" instead? Seems like that may be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

# fallback to using the latest cache if no exact match is found
- dependencies-
- run:
name: Install
command: yarn install
- save_cache:
paths:
- node_modules
key: dependencies-{{ checksum "package.json" }}
- run:
name: Check Prettier, ESLint, Flow
command: yarn ci-check