Skip to content

Small tweaks to the ReactDOMServer doc. #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Conversation

aickin
Copy link
Contributor

@aickin aickin commented Oct 11, 2017

This is a continuation of facebook/react#10436 , most of which made it into the docs already. The only things this PR adds are

  • Removes reference to data-reactid, which no longer exists.
  • Changes phrasing for renderToStaticMarkup and renderToStaticNodeStream, saying that they save "some" bytes rather than "a lot of" bytes.
  • Copies over several of the sentences from the renderToString/renderToStaticMarkup to their streaming counterparts to make the docs more consistent.

Thanks!

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 67dfc2d

https://deploy-preview-128--reactjs.netlify.com

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Thanks for the follow up

@bvaughn bvaughn merged commit dbfc999 into reactjs:master Oct 11, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants