Fix blog post content about DOM Attributes #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 8c04bfc |
bvaughn
reviewed
Oct 10, 2017
| @@ -163,7 +163,7 @@ Below is a detailed list of them. | |||
| ``` | |||
|
|
|||
| React 15: Converts `NaN`s to strings and passes them through. | |||
| React 16: Warns and ignores them. | |||
| React 16: Converts `NaN`s to strings and warns about them. | |||
There was a problem hiding this comment.
Should we clarify a bit more?
React 16: Converts
NaNs to strings and passes them through with a warning.
|
@bvaughn sounds good, just updated the PR |
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
* Translate getting started * Apply translation review suggestions * Apply translation review suggestions * Fix something missing title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Dan here the blog post is not correct and should be fix. Let me know if I should change the wording though.