Skip to content

Fix missing closing braces in code samples #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fuchodeveloper
Copy link
Contributor

Fixed the closing braces for the code samples at https://reactjs.org/docs/lifting-state-up.html#lifting-state-up

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@reactjs-bot
Copy link

reactjs-bot commented Oct 10, 2017

Deploy preview ready!

Built with commit 23fac76

https://deploy-preview-112--reactjs.netlify.com

@gaearon
Copy link
Member

gaearon commented Oct 10, 2017

These aren't missing braces, they just show a part of the code.
Maybe we can add

// ...

instead?

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fuchodeveloper
Copy link
Contributor Author

fuchodeveloper commented Oct 10, 2017

Ok.
Adding
// ...
Would be great.

@gaearon
Copy link
Member

gaearon commented Oct 10, 2017

Mind making the change? Thanks!

@fuchodeveloper
Copy link
Contributor Author

fuchodeveloper commented Oct 10, 2017

Sure thing.
Done.

@gaearon
Copy link
Member

gaearon commented Oct 10, 2017

Seems like we fixed this in #115.

@gaearon gaearon closed this Oct 10, 2017
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants