Skip to content

Clarify idea for improvement 1. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Clarify idea for improvement 1. #101

merged 1 commit into from
Oct 10, 2017

Conversation

maxhumme
Copy link
Contributor

@maxhumme maxhumme commented Oct 9, 2017

When I was working through this, I found it not completely clear what was meant by 'instead of "6"'. I assumed the document refers to the move numbers in the move list, so that's what this change clarifies.

@reactjs-bot
Copy link

reactjs-bot commented Oct 9, 2017

Deploy preview ready!

Built with commit 2ef21df

https://deploy-preview-101--reactjs.netlify.com

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both wordings are a little confusing 😅 but this seems the lesser confusing of the 2

@bvaughn
Copy link
Contributor

bvaughn commented Oct 9, 2017

Looks like there's a merge conflict (prob b'c of PR #102). Rebase?

When I was working through this, I found it not completely clear what was meant by 'instead of "6"'. I assumed the document refers to the move numbers in the move list, so that's what this change clarifies.
@maxhumme
Copy link
Contributor Author

Rebased. Should work now...

@bvaughn bvaughn merged commit 3350855 into reactjs:master Oct 10, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Oct 10, 2017

Thanks~

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants