Closed
Description
The package.json
defines a check-all
script that runs Prettier, Lint, and Flow. This script is intended to be run before commit to help catch inconsistent formatting or type errors. However we are not currently running this check as part of CI.
- To fix this, first create a script that does the following (done via Create script for checks (prettier, lint, flow) in CI #93)
- Run Prettier and fail if any modifications are made. (This means that the committed code isn't formatted correctly.)
- Run ESLint and fail if there are any errors.
- Run Flow and fail if there are any errors.
- Fix all pre-existing errors so the new
yarn ci-check
task passes inmaster
. (done via Added fbjs eslint config, fixed lint errors and warnings #104) - Hook this new script into CircleCI to run automatically for every PR. (A React team member will need to help with this step.) (done via Add CircleCI config #131)