Skip to content

OnClick event clash with AgGrid v26.1 #424

Closed
@ATrogolo

Description

@ATrogolo

Hi,
I've found an incompatibility with the last update of with AgGrid library (v.26.1.0).

The issue appears when a react-tabs component contains an ag-grid.
The issue is triggered by the onClick event when selecting a column menu item (general / filter / columns) (https://www.ag-grid.com/javascript-data-grid/column-menu/#example-column-menu).

React-tabs has a method to check if the click event belongs to the component.
To perform this check it checks if the "target" item has a role === 'tab'.

Now, the AgGrid 'button' of the column item menu has attribute role = "tab" too and it clashes with your check.

Packages versions:

  • ag-grid: 26.1.0
  • react-tabs (both 3.0.0 and latest: 3.2.2)

Could you consider an update to your method?
This issue could affect all ag-grid and react-tabs users.

Here a repository which reproduce the issue: https://github.com/ATrogolo/aggrid-v26.1-react-tabs-clash

Please let me know what you think about this.
Andrea

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions