Skip to content

Let’s test against Rails 5.2 #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2018
Merged

Conversation

ttanimichi
Copy link
Member

No description provided.

@ttanimichi ttanimichi changed the title WIP: Let’s test against Rails 5.2 Let’s test against Rails 5.2 May 7, 2018
@ttanimichi
Copy link
Member Author

The travis build was failed, but it has nothing to do with this patch.
https://travis-ci.org/reactjs/react-rails/builds/375740147

@BookOfGreg
Copy link
Member

@ttanimichi You have been helping around here a lot lately. Would you consider helping as a maintainer?
Same vein as #785

@BookOfGreg BookOfGreg merged commit a91e0d8 into reactjs:master May 8, 2018
@ttanimichi
Copy link
Member Author

@BookOfGreg Thank you for the offer! I’d be glad to become a maintainer.

@BookOfGreg
Copy link
Member

@zpao Can you please grant ttanimichi member to the reactjs rails team?

@zpao
Copy link
Member

zpao commented May 11, 2018

👍 all set! Thanks for helping out @ttanimichi!

@ttanimichi
Copy link
Member Author

Thank you!

@ttanimichi ttanimichi deleted the rails52 branch May 11, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants