Move package.json to top level #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting package.json at the top level follows convention of Webpacker and other gems that bundle JS. It allows sharing of the licence and readme when looking at the package on NPM
|
👍 Makes sense to me, I see how you updated If not, you can always tweak and make another quick release 😅 |
|
Cool. I published as Just getting myself in a knot slightly with these branches, just me having teething issues is all. I noticed in the |
|
https://www.npmjs.com/package/react_ujs That looks better 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the package.json to the top level so it automatically picks up the readme and licence, to stop our NPM entry being to empty.
Not 100% it will work as intended, is there a nice way of verifying that the
npm pack(doc) will do what we want before I break the NPM package @rmosolgo ?This is based on the pattern of webpacker's package.
Edit: I could make a prerelease:
https://medium.com/@mbostock/prereleases-and-npm-e778fc5e2420