feat(versions) add VERSIONS.md for gem/React versions #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Travis needs a "4/5 not bad" response :S |
rmosolgo
pushed a commit
that referenced
this pull request
Apr 2, 2015
feat(versions) add VERSIONS.md for gem/React versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As expressed in #133, we need a way to better express how gem versions and react versions compare.
I've taken a page from jquery-rails's book and added a
VERSIONS.mdfile with info about bundled versions. I also put information there about other ways of controlling the React version.Right now, the update plan is pretty low-tech: I added comments to gem version and
react-sourceversion to remind anyone to updateVERSIONS.md. In my opinion, this is better than what we have now and good enough for the time being.If you prefer, we could add a rake task for updating the react version. I think it's overkill (more maintenance overhead than the comments, more likely to break in the future), but jquery-rails does something similar and I'm open to it.