Skip to content

Proper filenames #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2013
Merged

Proper filenames #18

merged 1 commit into from
Dec 4, 2013

Conversation

khelben
Copy link

@khelben khelben commented Dec 2, 2013

This is a stupid one but it hurts my eyes.

Renamed lib/react/rails/railstie.rb to lib/react/rails/railtie.rb

@zpao
Copy link
Member

zpao commented Dec 2, 2013

facepalm_227785

Thanks! If you can sign the CLA, I can merge this right in - https://developers.facebook.com/opensource/cla

@khelben
Copy link
Author

khelben commented Dec 3, 2013

Do you need prove of me signing the CLA? How would I do that?

@zpao
Copy link
Member

zpao commented Dec 4, 2013

Nope, I can look you up with our internal tool, you're good to go!

Thanks a lot for this. I misspelled this so many times during my initial work on this, but I thought I did the right thing when I actually wrote code… :hurtrealbad:

zpao added a commit that referenced this pull request Dec 4, 2013
@zpao zpao merged commit ee4a5b5 into reactjs:master Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants