Skip to content

Update README.md #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Update README.md #1041

merged 1 commit into from
Nov 4, 2019

Conversation

yosefbennywidyo
Copy link
Contributor

Add command, it's required to run rails webpacker:install first if not:

webpack binstubs not found.
Have you run rails webpacker:install ?
Make sure the bin directory or binstubs are not included in .gitignore
Exiting!

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

Add command, it's required to run `rails webpacker:install` first if not:
```
webpack binstubs not found.
Have you run rails webpacker:install ?
Make sure the bin directory or binstubs are not included in .gitignore
Exiting!
```
@BookOfGreg
Copy link
Member

That's only needed if you chose to upgrade a sprockets app to webpack, so for majority of people not needed. However since it's idempotent no harm in it. 👍 thanks for the contribution.

@BookOfGreg BookOfGreg merged commit ac80f08 into reactjs:master Nov 4, 2019
@yosefbennywidyo yosefbennywidyo deleted the patch-1 branch November 5, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants