Use State to trigger open & close #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found that `handleProps` is called for each render of the parent container. This up calling `close` and thereby creating warnings in my console due to https://github.com/rackt/react-modal/blob/master/lib/helpers/focusManager.js#L36 What I've done is update the component to use its `state` to keep track of whether it's open or not. This fixes the warnings but may not be the most elegant solution to the problem.
…tch-1 Conflicts: lib/components/ModalPortal.js
|
@tazsingh I believe that this has already been resolved in version 0.0.6. Please update and let me know if the warnings still occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that
handlePropsis called for each render of the parent container. This up callingcloseand thereby creating warnings in my console due to https://github.com/rackt/react-modal/blob/master/lib/helpers/focusManager.js#L36What I've done is update the component to use its
stateto keep track of whether it's open or not. This fixes the warnings but may not be the most elegant solution to the problem.