-
Notifications
You must be signed in to change notification settings - Fork 54
Sync with reactjs.org @ 2ab1ca50 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
A page could have 50 links, every one with the link text "Here" and it doesn't mean anything. Search engines rely on the fact that the link text says something about the link. The text "Here" doesn't mean anything to search engines. Using "Here" as link text has no semantic value.
Change > node whose contents has changed to > node whose contents have changed
Should hooks such as `useLayoutEffect`, `useEffect`, etc also be listed in the "Render phase lifecycles" section?
* Fix broken link * change underscores to hyphens Previous fix not correct. This actually fixes the link.
* Blogpost for v16.13.0 * Tweak * Update 2020-03-02-react-v16.13.0.md * update react/react-dom versions Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
…. (It wasn't part of that release.)
as well the right link to the changelog
As a general rule, `onClick` handlers should not be applied to non-interactive elements like a `div`. There is not substantive change to the code sample, but it doesn't provide a better example of semantic HTML for developers reading the documentation.
* Add redirect from old blog post url * Update 2020-02-26-react-v16.13.0.md
We still support it (and you can find this page in search), but we're transitioning away to community maintenance. So we're deemphasizing it on the website.
* add Edge extension link for Devtools * Update 2015-09-02-new-react-developer-tools.md
Deploy preview for pl-reactjs ready! Built with commit 4f63a66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 2ab1ca5
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.