Skip to content

docs: translate Reacting to Input with State #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2024
Merged

docs: translate Reacting to Input with State #610

merged 5 commits into from
Apr 5, 2024

Conversation

chez14
Copy link
Contributor

@chez14 chez14 commented Aug 27, 2023

Fixes #379 and closes #532.

Description

Translate the Reacting to Input with State page, continuing @JfrAziz's effort on translating the page.
Page URL:

@github-actions
Copy link

github-actions bot commented Aug 27, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@chez14
Copy link
Contributor Author

chez14 commented Aug 30, 2023 •
edited
Loading

Terms:

  • enumerate → menjabarkan (From JfrAziz's translation. Perfect choice of word.)
  • Mock → Model Visual?
    • Mocking → Pemodelan?
      Context: Mocking as in... just deliberately set the value to test things out.
  • Edge (as in State Machine): Edge

(I also accidentally closed this PR 🤦)

@chez14 chez14 closed this Aug 30, 2023
@chez14 chez14 reopened this Aug 30, 2023
@chez14 chez14 force-pushed the chez14/translate-reacting-input-with-state branch from c18ef7b to 3196028 Compare September 2, 2023 11:56
@chez14 chez14 marked this pull request as ready for review September 2, 2023 12:03
@chez14
Copy link
Contributor Author

chez14 commented Sep 2, 2023

Hi @zainfathoni,

This PR is ready for review, can you please review this PR?

Please let me know if you have any feedback or questions.

Thank you!

@chez14 chez14 mentioned this pull request Sep 2, 2023
Closed
zainfathoni
zainfathoni requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR.
However, almost every line I reviewed so far needs many corrections. So, I stopped reviewing at line 26.

Please:

  1. Address all my comments so far (up to line 26).
  2. Re-review your translations from line 27 onwards to ensure you get all the words and formatting correct.
  3. If necessary, you may find DeepL helpful in assisting your translation effort. @resir014 has been using it for quite some time.
    For instance, you can see that DeepL's translation result for line 7 is quite close to my suggestions so far. docs: translate Reacting to Input with State #610 (comment)

image

@chez14
Copy link
Contributor Author

chez14 commented Sep 9, 2023

Noted, I'll update accordingly. Thank you!

I used DeepL for translation but some of the sentences sound off, so I rephrase it manually. I thought the missing context are safe to dismiss, but I should have reconsidered it again.

I'll recheck the translations again, and let you know when I'm done.

Thank you so much!

@resir014
Copy link
Member

Hi, any updates? @chez14

@chez14
Copy link
Contributor Author

chez14 commented Oct 17, 2023

Sorry, I don't think i can finish this by this week. I'll try to update the other PR first and see how much progress I can do for this PR, and see from there.

Thank you!

@resir014 @zainfathoni
Apply suggestions from code review
b57d2ff 
Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
id-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 4:03am

@resir014 resir014 requested a review from zainfathoni February 28, 2024 04:03
mhaidarhanif
mhaidarhanif approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@resir014 resir014 closed this Apr 5, 2024
@resir014 resir014 reopened this Apr 5, 2024
@resir014 resir014 merged commit f7f18e8 into reactjs:main Apr 5, 2024
resir014 added a commit that referenced this pull request Apr 5, 2024
@resir014 @JfrAziz @chez14
docs: translate Reacting to Input with State (#610)
3b25a57 
Co-Authored-By: Jafar Aziz <aziz@jafaraziz.com>
Co-Authored-By: Chris Qiang <chris@christianto.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@zainfathoni zainfathoni zainfathoni approved these changes

@mazipan mazipan Awaiting requested review from mazipan

@resir014 resir014 Awaiting requested review from resir014

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reacting to Input with State
5 participants
@chez14 @resir014 @mhaidarhanif @zainfathoni @JfrAziz