Skip to content

docs: translate Suspense page #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 8, 2024

Conversation

chez14
Copy link
Contributor

@chez14 chez14 commented Jul 30, 2023

Fixes #416 and closes #523

Description

This PR adds translation to "Suspense" page, continuing @maulanasdqn effort.

Translate the Suspense page.
Page URL:

@github-actions
Copy link

github-actions bot commented Jul 30, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@chez14
Copy link
Contributor Author

chez14 commented Aug 6, 2023

I'm having hard time translating these terms:

  • Suspend → Ditangguhkan?
  • Fallback → fallback
  • Boundary → Batasan
  • Lazy-loading → Lazy-load

For now, I'll take notes on all of these terms and will consult while submitting this PR for review.

@resir014
Copy link
Member

Suspend → Ditangguhkan?
Fallback → fallback
Boundary → Batasan
Lazy-loading → Lazy-load

Yep, all these should be correct. @chez14

@chez14
Copy link
Contributor Author

chez14 commented Aug 21, 2023

I got quite busy past few weeks, I'm targeting to finish this MR/PR by this week.

@chez14 chez14 force-pushed the chez14/translate-suspense branch from d716969 to 7174d59 Compare August 26, 2023 11:16
@chez14
Copy link
Contributor Author

chez14 commented Aug 26, 2023

Hi @resir014 and @zainfathoni,

This PR is ready for review, please let me know if you have any feedback.

Thank you!


Hi @maulanasdqn,

Thank you for the initial translation work. As most of the work were done by you, I think it's fair to ask for your feedback too when you're able to review the PR haha.

Thank you!

@chez14 chez14 mentioned this pull request Sep 2, 2023
@resir014 resir014 self-requested a review September 8, 2023 15:35
@resir014
Copy link
Member

@chez14 Sorry for the delay, I can help in tagging the reviewers for now. @mhaidarhanif @zainfathoni @mazipan @r17x

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review with suggestion

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions.

@mhaidarhanif
Copy link
Collaborator

@chez14 Just reviewed with some more suggestions.

cc @resir014 @zainfathoni @r17x @mazipan

@resir014
Copy link
Member

Hi, any updates to this? @chez14

@chez14
Copy link
Contributor Author

chez14 commented Oct 17, 2023

Ah sorry, i missed this notification. I've been quite busy with office work lately, I'll try to update this PR by this week.

Thank you!

@resir014
Copy link
Member

resir014 commented Nov 5, 2023

@chez14 Hi, are you still able to work on this? If you're unable to work on this within the next 3-5 days, we can take over your PRs.

@maulanasdqn
Copy link
Contributor

maulanasdqn commented Jan 13, 2024

@resir014 can i continue this work? cc @chez14

@resir014
Copy link
Member

Yes, feel free to pick up this PR! @maulanasdqn

Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
id-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 2:20am

Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
@resir014 resir014 requested a review from mhaidarhanif April 8, 2024 02:20
@resir014
Copy link
Member

resir014 commented Apr 8, 2024

Picking this up again since we need to get the remaining pages translated since we have some other new pages to translate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Suspense>
4 participants