Skip to content

docs: translate JavaScript in JSX with Curly Braces #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 13, 2023
Merged

docs: translate JavaScript in JSX with Curly Braces #534

merged 9 commits into from
Jun 13, 2023

Conversation

naufaldi
Copy link
Contributor

@naufaldi naufaldi commented May 2, 2023

Closes #425

Description

Translate the JavaScript in JSX with Curly Braces page.
Page URL: JavaScript in JSX with Curly Braces

@naufaldi naufaldi marked this pull request as draft May 2, 2023 07:04
@naufaldi naufaldi changed the title feat: translate to indonesia in line 90 docs: translate to indonesia in line 90 May 2, 2023
@naufaldi naufaldi changed the title docs: translate to indonesia in line 90 docs: JavaScript in JSX with Curly Braces May 2, 2023
@naufaldi naufaldi marked this pull request as ready for review May 15, 2023 08:37
resir014
resir014 requested changes May 18, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review done. Some changes needed @naufaldi:

@mazipan mazipan requested a review from r17x May 18, 2023 08:01
@mhaidarhanif
Copy link
Collaborator

@naufaldi need to resolve the requests from @resir014

@github-actions
Copy link

github-actions bot commented Jun 6, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mazipan
mazipan reviewed Jun 6, 2023
View reviewed changes
@mhaidarhanif
Copy link
Collaborator

@naufaldi also need to resolve the new requests from @mazipan along with the ones from @resir014

@resir014
Copy link
Member

@naufaldi Hi, any updates? If there are no updates within the next 24 hours, the maintainers will take over this PR.

@naufaldi
Copy link
Contributor Author

naufaldi commented Jun 12, 2023 •
edited
Loading

Sorry for being idle in one month, already make change and update with new translation @resir014

resir014
resir014 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@resir014 resir014 changed the title docs: JavaScript in JSX with Curly Braces docs: translate JavaScript in JSX with Curly Braces Jun 13, 2023
@resir014 resir014 merged commit 1b04a19 into reactjs:main Jun 13, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@naufaldi @mazipan
@mhaidarhanif @FelixFern
docs: translate JavaScript in JSX with Curly Braces (reactjs#534)
076c7b0 
Co-authored-by: Naufaldi Rafif S <naufaldi.rafif@efishery.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan left review comments

@resir014 resir014 resir014 approved these changes

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@r17x r17x Awaiting requested review from r17x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript in JSX with Curly Braces
4 participants
@naufaldi @mhaidarhanif @resir014 @mazipan