Skip to content

docs: translate renderToString section #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 9, 2023

Conversation

hisamafahri
Copy link
Contributor

Close #462

Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use asterisk (*) instead of underscore (_) for make italic text.

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented May 2, 2023

@hisamafahri Each tree need to be translated to pohon

Need help with others to make sure we translate tree to pohon (*tree*) as in all other translated pages / merged PRs @r17x @resir014 @zainfathoni @mazipan

@hisamafahri
Copy link
Contributor Author

Each tree need to be translated to pohon

Need help with others to make sure we translate tree to pohon (*tree*) as in all other translated pages / merged PRs @r17x @resir014 @zainfathoni @mazipan

@mhaidarhanif I've thought about that too. But looking back using pohon is really confusing from the reader's standpoint.

I've asked few colleagues of mine, and they prefer to use tree instead.

But, if the maintainers have decided that, I'll be happy to follow that 😁

@zainfathoni
Copy link
Collaborator

zainfathoni commented May 2, 2023

Each tree need to be translated to pohon

Need help with others to make sure we translate tree to pohon (*tree*) as in all other translated pages / merged PRs @r17x @resir014 @zainfathoni @mazipan

@mhaidarhanif I've thought about that too. But looking back using pohon is really confusing from the reader's standpoint.

I've asked few colleagues of mine, and they prefer to use tree instead.

But, if the maintainers have decided that, I'll be happy to follow that 😁

It's just a matter of habit. I have been using pohon, cabang, akar, and daun for years since my college and all the students in the whole class had no problems with them. We understood the modules well. I even used those words in my Indonesian paper and got an A score for the module. 😁

And you only need to do pohon (*tree*) once in the first usage of the page. After that, you may omit (*tree*) and only use pohon in it.

@hisamafahri
Copy link
Contributor Author

@zainfathoni Noted. Looks like we need to get used to use terms in Bahasa Indonesia more often from now on. 😂

@github-actions
Copy link

github-actions bot commented May 2, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor suggestions so far from skimming the text. I'll review it more thoroughly later tonight.

@r17x
Copy link
Collaborator

r17x commented May 5, 2023

Need review based on request changes by @zainfathoni

@mhaidarhanif
Copy link
Collaborator

@zainfathoni can check and approve if okay.

@mhaidarhanif mhaidarhanif dismissed zainfathoni’s stale review June 8, 2023 15:36

Others already approved

@mhaidarhanif
Copy link
Collaborator

@mazipan @r17x All changes approved and as @zainfathoni might be busy until next week so the last requested change has been dismissed.

@r17x r17x force-pushed the renderToString branch from 6638e34 to be34bfa Compare June 9, 2023 07:21
@r17x r17x merged commit 10d1d04 into reactjs:main Jun 9, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renderToString
5 participants