Skip to content

docs: translate Referencing Values with Refs page #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 2, 2023
Merged

docs: translate Referencing Values with Refs page #479

merged 16 commits into from
May 2, 2023

Conversation

irsyaadbp
Copy link
Contributor

@irsyaadbp irsyaadbp commented Apr 28, 2023 •
edited
Loading

Closes #387

@irsyaadbp irsyaadbp force-pushed the docs/translation/referencing-value-with-refs branch from 74b54d8 to fdd8611 Compare April 29, 2023 11:05
r17x
r17x requested changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untuk menjaga konsistensi, gunakan * dari pada _ untuk tulisan yang italic

@irsyaadbp irsyaadbp force-pushed the docs/translation/referencing-value-with-refs branch from fdd8611 to 05c380d Compare April 30, 2023 02:16
@irsyaadbp irsyaadbp requested a review from r17x April 30, 2023 02:19
@irsyaadbp irsyaadbp force-pushed the docs/translation/referencing-value-with-refs branch from 05c380d to 2e54053 Compare April 30, 2023 02:20
arfianadam
arfianadam reviewed Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@arfianadam arfianadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st review.

@irsyaadbp irsyaadbp requested a review from arfianadam April 30, 2023 07:42
arfianadam
arfianadam reviewed Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@arfianadam arfianadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd review.

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 30, 2023 •
edited
Loading

@irsyaadbp Please resolve all review comments from @r17x to reconfirm all the fixed changes (by clicking all the Resolve conversation buttons). Except for one or some of them haven't been resolved.

@github-actions
Copy link

github-actions bot commented Apr 30, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@irsyaadbp irsyaadbp requested a review from arfianadam May 1, 2023 04:40
@irsyaadbp
Copy link
Contributor Author

@irsyaadbp Please resolve all review comments from @r17x to reconfirm all the fixed changes (by clicking all the Resolve conversation buttons). Except for one or some of them haven't been resolved.

image
@mhaidarhanif where is the button resolve conversation? but i already submit rerequest review

@arfianadam
Copy link
Collaborator

@irsyaadbp should be right here
image

Irsyaad Budi added 12 commits May 2, 2023 18:37
@r17x r17x force-pushed the docs/translation/referencing-value-with-refs branch from 66e32b5 to 0d99f19 Compare May 2, 2023 11:37
@r17x r17x merged commit 7391f42 into reactjs:main May 2, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@irsyaadbp @r17x
docs: translate Referencing Values with Refs page (#479)
2d0f232 
Co-authored-by: Irsyaad Budi <irsyaad@privyid.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x approved these changes

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

@resir014 resir014 Awaiting requested review from resir014

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@arfianadam arfianadam Awaiting requested review from arfianadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referencing Values with Refs
4 participants
@irsyaadbp @mhaidarhanif @arfianadam @r17x