Skip to content

Add translated terms to TRANSLATION.md #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Conversation

carburo
Copy link
Member

@carburo carburo commented Feb 1, 2019

As more contributions are coming we need different translations to be consistent. I added possible translations to some common terms.

TRANSLATION.md Outdated
| string | *string* |
| template literals | *template literals* |
| state | estado |
| string | cadena de texto |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think string should not be changed, it is a widely used term across the industry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you start learning about programming (and I think this applies to any language) you learn primitives, and with primitives comes string, boolean, number...etc.

That said, if someone reads string they would know that we're talking about cadena de texto.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to keep string without translate it

Copy link
Contributor

@LuisRevillaM LuisRevillaM Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cadena de caracteres works too.

How can I translate array and keys ?

Array could be translated as arreglo en Spanish, but while there is people who use it (usually un universities) I think array is a commonly used term in Spanish.

Key are llaves, but again is something used as is in Spanish too.

I think keys as in keys of an object, could be propiedades de un objeto. arreglos have índices that are also propiedades when seen as objetos.

TRANSLATION.md Outdated
| template literals | *template literals* |
| state | estado |
| string | cadena de texto |
| template literals | plantilla de cadena (de texto) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds so weird in Spanish 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the same reasons as #23 (comment), I think we should leave template literals as is, but really I don't have strong opinions about it though.

Copy link

@gariasf gariasf Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen "string" defined as cadena de texto or cadena de caracteres, but I've never seen it used like that.
Same thing goes for "template literals".

For me those are terms that encapsulate a concept and although they can be translated, the meaning just isn't the same.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we should leave template literals as is, also string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would incline towards cadena de caracteres for string.

For template literals, I think plantillas de texto does a great job, though it still requires some consensus behind it to fully convey the meaning.

@EzequielMonforte
Copy link
Contributor

EzequielMonforte commented Feb 1, 2019

How can I translate array and keys ?

@sergiodxa
Copy link

How can I translate array and keys ?

Array could be translated as arreglo en Spanish, but while there is people who use it (usually un universities) I think array is a commonly used term in Spanish.

Key are llaves, but again is something used as is in Spanish too.

@@ -12,20 +12,20 @@ Suggestion on words and terms:

| Original word/term | Suggestion |
| ------------------ | ---------- |
| arrow function | *arrow function* |
| arrow function | función flecha |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would let arrow function without translation, it's used that way in a lot of Spanish tutorials and articles.

@@ -12,20 +12,20 @@ Suggestion on words and terms:

| Original word/term | Suggestion |
| ------------------ | ---------- |
| arrow function | *arrow function* |
| arrow function | función flecha |
| bug | error |
| Bundler | *Bundler* |
| camelCase | *camelCase* |
| callback | *callback* |
| controlled component | *controlled component* |
| debugging | depuración |
| library | biblioteca |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the correct term is biblioteca but the majority of the community use librería as a translation of library and is more commonly used. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this one too, I can say that Librería is way more common than Biblioteca.

Copy link
Member Author

@carburo carburo Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both librería and biblioteca are of common use. The difference is that while librería is a bad semantic copy, biblioteca is an straightforward translation of the term.

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carburo,

I think we should stick to some universal words in the development world, for example, I think that
arrow function, string and template literals should stay in English. As @sergiodxa mentioned, you can find those terms in a lot of tutorials in Spanish, it's pretty common, so I see no point in changing those. Those changes could confuse people down the road.

@LuisRevillaM
Copy link
Contributor

Hey @carburo,

I think we should stick to some universal words in the development world, for example, I think that
arrow function, string and template literals should stay in English. As @sergiodxa mentioned, you can find those terms in a lot of tutorials in Spanish, it's pretty common, so I see no point in changing those. Those changes could confuse people down the road.

This is true. However a lot of academic literature out there treats strings as cadenas de caracteres, which is a very useful way of thinking about strings in spanish, IMO.

Thinking about template literals in terms of plantillas de texto is also very helpful, IMO for the spanish-thinking brain.

Maybe we could address the relationship between the translation and the more common english word, perhaps in the glossary.

@gariasf gariasf mentioned this pull request Feb 1, 2019
@carburo
Copy link
Member Author

carburo commented Feb 1, 2019

I think we probably get attached to some terms because that's what we learned. For example in the university, we always used Spanish terms (arreglos, cadenas (de caracteres), llave, etc.) I removed the most controversial terms from the PR in order to move forward with the style guide as I think it is really important to have a base for making reviews for future contributions. We could later discuss those aspects where we don't have yet a consensus.

@carburo carburo merged commit f181fa4 into reactjs:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants