Skip to content

useId page translation #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

remahmoud
Copy link
Contributor

No description provided.

@AhmedBaset
Copy link
Collaborator

Please, translate the reference in the src/sidebar reference.json for your page.

@AhmedBaset AhmedBaset added the update needed This PR needs update since last commit label May 30, 2023
@remahmoud
Copy link
Contributor Author

@A7med3bdulBaset in sidebarReference.json, the title field is the name of useId hook and it can't be translated. If I'm confused or I'm wrong, you can explain to me

@AhmedBaset
Copy link
Collaborator

You are right. I'm sorry.

@AhmedBaset AhmedBaset added need-review and removed update needed This PR needs update since last commit labels May 30, 2023
@remahmoud
Copy link
Contributor Author

You are right. I'm sorry.

Thanks 👍


---

## Usage {/*usage*/}
## الإستخدام {/*usage*/}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

الاستخدام بهمزة وصل

@@ -96,7 +96,7 @@ In regular HTML, you would write it like this:
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

يفضل ترجمة النص داخل الكود

@@ -96,7 +96,7 @@ In regular HTML, you would write it like this:
</p>
```

However, hardcoding IDs like this is not a good practice in React. A component may be rendered more than once on the page--but IDs have to be unique! Instead of hardcoding an ID, generate a unique ID with `useId`:
مع ذلك، تضمين المعرفات بهذا الشكل ليس طريقة جيدة في ريأكت. يمكن أن يتم عرض المكون أكثر من مرة على الصفحة ولكن يجب أن تكون المعرفات فريدة! بدلا من تضمين معرف ثابت، يمكنك توليد معرف فريد باستخدام `useId`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

كلمة React لا تحتاج لترجمة

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please checkout my last commit to see edits

@AhmedBaset AhmedBaset merged commit 5967e00 into reactjs:main Jun 1, 2023
@AhmedBaset
Copy link
Collaborator

تم دمج الفرع
ترجمتك ممتازة
يمكنك أخذ صفحة أخرى الآن

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@remahmoud
Copy link
Contributor Author

@A7med3bdulBaset
شكرا

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants