Skip to content

add logo for social card #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

add logo for social card #945

merged 1 commit into from
Mar 1, 2023

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Mar 1, 2023

Add logo that works with social cards

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea rmorshea marked this pull request as ready for review March 1, 2023 08:18
@Archmonger
Copy link
Contributor

I propose we play around with the ReactPy text font a bit.

Maybe Roboto Bold or Segoe UI?

@rmorshea
Copy link
Collaborator Author

rmorshea commented Mar 1, 2023

I'm not picky. The font I chose was literally the default sans font in Inkscape. Care to make that change?

@Archmonger
Copy link
Contributor

I can work on it in a follow up PR

@rmorshea
Copy link
Collaborator Author

rmorshea commented Mar 1, 2023

Speaking of bolding things though. Do you think the fact that there are snakes in the logo is clear at smaller scales? Obviously once it's small enough you can't tell. But when it's this big it seems like it might be too subtle:
image

@rmorshea rmorshea merged commit 0a66918 into main Mar 1, 2023
@rmorshea rmorshea deleted the social-card branch March 1, 2023 08:44
@Archmonger
Copy link
Contributor

Archmonger commented Mar 1, 2023

Nope, not clear at all.

That's a common design issue with any intricate design. Same reason why Python's snakes look so stupid. Making geometry simplified and oversized is the only way to retain visual clarity a small sizes.

@rmorshea
Copy link
Collaborator Author

rmorshea commented Mar 1, 2023

Yup. I think I'm at the limits of my creative abilities here though. Probably need to pay someone if we want something better. Who knows, maybe it's too difficult to make work, but I'm kind of attached to the concept at least.

@Archmonger
Copy link
Contributor

I agree we should stick with the concept, it's the only thing that logically conveys our project. I'm okay with pitching in for a graphics artist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants