Refactor Dispatchers #353
Merged
Refactor Dispatchers #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
fix-298
branch
4 times, most recently
from
a3e58ca to
ce5ffab
Compare
Simplify them greatly by making them normal functions. This avoids a lot of indirection and complexity caused by inheritance. In addition this fixes some impropper usages of TaskGroups which was causing problems in the SharedClientStateServer implementations. This refactor also allowed us to get rid of the clunky HasAsyncResources util class. In the end it just added confusion.
|
Hell yeah! Whenever this build gets moved over to PyPi I will begin Conreq integrations. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #298, #352
This switches from a class-based approach to one that leverages pure functions. While the logic itself isn't any simpler, it was easier to implement (and hopefully understand) correctly. This conversion was motivated by several bugs that had cropped up and that wouldn't be easily fixable without substantial changes refactor or not.
The one thing that still gets me is the lack of uniformity in usage, but I suppose that's alright given how different the "shared" vs "single" view implementations are.