-
-
Notifications
You must be signed in to change notification settings - Fork 324
Update PR workflow / workspace #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
604bc32
1919158
e2feeb3
1ce169d
3bd8b69
36bc76c
f9cb181
9b09ae3
3226177
ddeb91f
c63219d
a2e2418
ca61e74
2062f06
9eb7226
8e1fb38
cb940f0
afa0b5f
4a14d5c
ba4845a
88818f9
926211e
9e9664c
9d71dc6
0be93c7
30b09eb
cdadb0d
3996ae6
ae55330
200ae13
f6b6cd2
131fe0a
aac0dc2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
*By submitting this pull request you agree that all contributions to this project are made under the MIT license.* | ||
|
||
## Issues | ||
|
||
<!-- Link the issues this change resolves, or describe them --> | ||
<!-- By submitting this pull request you agree that all contributions to this project are made under the MIT license. --> | ||
|
||
## Summary | ||
|
||
<!-- Describe how these changes resolve the aforementioned issues --> | ||
|
||
## Issues | ||
|
||
<!-- Link the issues this change resolves, or describe them --> | ||
|
||
Archmonger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
## Checklist | ||
|
||
- [ ] Tests have been included for all bug fixes or added functionality. | ||
- [ ] The `changelog.rst` has been updated with any significant changes. | ||
- [ ] Tests have been included for all bug fixes or added functionality. | ||
- [ ] The `changelog.rst` has been updated with any significant changes. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ pip-wheel-metadata | |
|
||
# --- IDE --- | ||
.idea | ||
.vscode | ||
.vscode/*/ | ||
|
||
# --- JS --- | ||
node_modules | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"recommendations": [ | ||
"eamodio.gitlens", | ||
"github.vscode-pull-request-github", | ||
"wholroyd.jinja", | ||
"esbenp.prettier-vscode", | ||
"ms-python.vscode-pylance", | ||
"ms-python.python", | ||
"mrmlnc.vscode-autoprefixer", | ||
"gruntfuggly.todo-tree", | ||
"sourcery.sourcery", | ||
"njpwerner.autodocstring", | ||
"github.copilot" | ||
] | ||
} |
Archmonger marked this conversation as resolved.
Show resolved
Hide resolved
Archmonger marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
{ | ||
"editor.detectIndentation": false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure why we need to configure this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without customizing this, sometimes VS Code will try to use tabs instead of spaces depending on the file type. |
||
"editor.formatOnSave": true, | ||
"python.linting.enabled": true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is already the default There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Setting |
||
"python.linting.flake8Enabled": true, | ||
"python.linting.pylintEnabled": true, | ||
"python.linting.mypyEnabled": true, | ||
Archmonger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"python.analysis.typeCheckingMode": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is already the default except on VSCode insiders There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we keep it off in anticipation of the insiders build coming to main? |
||
"python.languageServer": "Pylance", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Already the default if installed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Setting |
||
"python.formatting.provider": "black", | ||
"isort.args": [ | ||
"--src=${workspaceFolder}" | ||
], | ||
"terminal.integrated.scrollback": 10000, | ||
"git.autofetch": true, | ||
"prettier.tabWidth": 4, | ||
"prettier.useTabs": true, | ||
"prettier.endOfLine": "auto", | ||
"prettier.proseWrap": "never", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I use all the defaults for Prettier. I also think it will auto detect project configuration by looking for one of the places it might be set: https://prettier.io/docs/en/configuration.html There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without |
||
"autoprefixer.formatOnSave": true, | ||
"files.associations": { | ||
"**/requirements/*.txt": "pip-requirements", | ||
Archmonger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"*.py-tpl": "python", | ||
"**/templates/**.html": "jinja", | ||
"**/template/**.html": "jinja", | ||
}, | ||
"[jsonc]": { | ||
"editor.defaultFormatter": "vscode.json-language-features" | ||
}, | ||
"[json]": { | ||
"editor.defaultFormatter": "vscode.json-language-features" | ||
}, | ||
"[javascript]": { | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
}, | ||
"[css]": { | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
}, | ||
"[python]": { | ||
"editor.defaultFormatter": "ms-python.python", | ||
"editor.codeActionsOnSave": { | ||
"source.organizeImports": true | ||
} | ||
}, | ||
"files.insertFinalNewline": true | ||
} |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.