Skip to content

Stale event handlers can reside in the client #896

Closed
@Archmonger

Description

@Archmonger

Current Situation

A consequence of this change is that now stale event handlers can stay within the client.

To replicate, restart the ASGI webserver while keeping an IDOM tab open. This will silently breaks all event handlers on reconnect.

2023-01-28T23:57:45-0800 | INFO | Ignored event - handler '3d35445264fb4d79a821e59f5961fc43' does not exist or its component unmounted

Proposed Actions

Look into the following

  • Is there a way of unmounting a React component that doesn't delete the DOM tree?
    • We might want to peek at the ReactDOM.unmountComponentAtNode source code and determine if we can do this
  • Can we potentially refresh all handlers within the client on reconnect?
  • Do we need to revert this PR?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions