Skip to content

Query params in package name for module_from_template not stripped #455

Closed
@rmorshea

Description

@rmorshea

The following call:

module_from_template("react", "@blueprintjs/core?module", cdn="https://unpkg.com")

Ends up saving a file with the name @blueprintjs/core?module.js when it should actually have stripped the query parameters and just saved @blueprintjs/core.js as the file name. This causes an issue when the browser tries to load the file from URL http://.../@blueprintjs/core?module.js and the server tries to look for a file called @blueprintjs/core (since the query params are not part of the path).

Perhaps we can use urllib to help parse this correctly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions