Skip to content

bump min client requirement #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2022
Merged

bump min client requirement #65

merged 3 commits into from
Feb 20, 2022

Conversation

rmorshea
Copy link
Contributor

@rmorshea rmorshea commented Feb 19, 2022

Related to breaking changes introduced by reactive-python/reactpy#680

@rmorshea rmorshea requested a review from Archmonger February 19, 2022 19:52
@rmorshea
Copy link
Contributor Author

We should have a PR template with a checklist that includes an item about updating the changelog.

@Archmonger
Copy link
Contributor

Archmonger commented Feb 20, 2022

I'd say we prioritize an automated workflow over a checklist. There amount of stuff outside of core that is fully dependent on core is only going to increase over time.


EDIT: I clearly misread. My actual response is below.

I don't know if a PR template solves these issues, since a lot of people create PRs using external tools (git CLI, GitHub Desktop, VSCode, etc). I think the best option is to use a "Welcome Message" CI workflow that makes a comment on each new PR with the checklist.

@Archmonger Archmonger merged commit ec59823 into main Feb 20, 2022
@Archmonger Archmonger deleted the upgrade-idom-client branch February 20, 2022 01:22
@rmorshea
Copy link
Contributor Author

Are you able to author releases?

@Archmonger
Copy link
Contributor

I don't believe so. I don't see this project under my PyPI account.

@rmorshea
Copy link
Contributor Author

You just need to be able to write a release on GitHub. I think we automated the release process.

@Archmonger
Copy link
Contributor

Ah- Yes I can. Will do so now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants