-
-
Notifications
You must be signed in to change notification settings - Fork 23
Use Django database router API #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@numpde would you be willing to help review this? I'm just not familiar enough with Django to understand the details here. I can cover a high-level review though. |
I'd like to get these system checks out ASAP, so I will merge this. If you decide to provide a post-merge review I will incorporate any changes in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request you agree that all contributions to this project are made under the MIT license.
Description
By default, all databases registered within Django are configured with identical columns. There may be some edge cases (#152) where this can be problematic. In order to to stop
ComponentSession
from existing on databases other than the user configuredREACTPY_DATABASE
, we need to create a Database Router.Changelog
reactpy_django.database.Router
must now be registered insettings.py:DATABASE_ROUTERS
wheneversettings.py:REACTPY_DATABASE
is set.Checklist:
Please update this checklist as you complete each item: