Skip to content

Add error checking to component template tag #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 27, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jun 25, 2023

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Description

There are some realistic edge cases where template rendering can occur before the reactpy_django database table exists (#152). This scenario is not common, but can exist if using HTML postprocessors.

  • Make it so that component template tag render failures don't cause catastrophic failure.
  • component template tag render failures now output a visual indicator if REACTPY_DEBUG_MODE is enabled.
  • Render <hr> via raw HTML within the tests so that component render failures don't break formatting
  • Fix typo on the docs
  • Ensure generate_object_name always returns a string

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger marked this pull request as ready for review June 25, 2023 06:34
@Archmonger Archmonger requested a review from a team as a code owner June 25, 2023 06:34
@Archmonger Archmonger requested a review from rmorshea June 25, 2023 06:38
@Archmonger Archmonger merged commit 204b47c into reactive-python:main Jun 27, 2023
@Archmonger Archmonger deleted the render-template-tag-errors branch June 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants