Skip to content

Add warning if poor performance is detected #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

Add warning if poor performance is detected #145

merged 1 commit into from
Jun 7, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented May 18, 2023 •
edited
Loading

Description

Added warning on poor system/cache/database performance. This is detected when ReactPy-Django takes longer than one second to perform a db_cleanup

Ref: #128

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger marked this pull request as ready for review May 19, 2023 10:06
@Archmonger Archmonger requested a review from a team as a code owner May 19, 2023 10:06
@Archmonger Archmonger requested a review from rmorshea May 24, 2023 08:00
@Archmonger
Copy link
Contributor Author

@rmorshea Can we merge this? Would help with user experience.

@Archmonger Archmonger merged commit f2d54e1 into reactive-python:main Jun 7, 2023
@Archmonger Archmonger deleted the performance-logging branch June 7, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archmonger @rmorshea