-
-
Notifications
You must be signed in to change notification settings - Fork 23
Rename django-idom
to reactpy-django
#131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Couple of things are needed for these tests to pass
|
I guess I figured that if we wanted to release a 1.0 version of ReactPy we'd need to remove the existing tag. Releasing a 0.45.0 version was mostly a result of me rushing to get a release out after I cleared out the previous releases on PyPI without knowing the consequences. |
Let's begin all names with |
Ok I see. I think we can merge despite the docs build failing. We'll just rehome the repo after merging and then rerun the tests. |
Can we re-release ReactPy as 1.0.0? |
|
idom
to reactpy
django-idom
to reactpy-django
The version number regressions of the JS and Python packages are really unnatural. |
The zero version on the Python package is temporary. I'm working on publishing a 1.0 release momentarily. |
v1.0 of reactpy Python lib had been released. |
@Archmonger, because GitHub aggressively strips all style from inline HTML there is no way to copy-paste a common markdown header to all our repos with a simple "ReactPy" to "ReactPy " title change and have it look like landscape SVG logo. From what I can tell, if you want the heading to look like the landscape logo on the main repo you're going to have to copy the SVG file and save a modified version in this repo. |
The only alternative I can think of would be to do something like:
Since for some reason The current logo doesn't really work well at this scale, but perhaps the best option for right now. |
By landscape, do you mean center justified? |
By landscape I mean this style of logo. |
I've done something similar using the For ReactPy Core... # ReactPy <img src="https://raw.githubusercontent.com/reactive-python/reactpy/main/branding/svg/reactpy-logo-square.svg" align="left" height="40"/> ReactPy
For the Django variant... # ReactPy Django <img src="https://raw.githubusercontent.com/reactive-python/reactpy/main/branding/svg/reactpy-logo-square.svg" align="left" height="40"/> ReactPy Django
|
Let's go with the logo setup you have there. After that I think this LGTM. |
The tagline ( Also there's no clean way to get a centered header while retaining the logo + text. All the solutions are too messy. Take a look at the design here: https://github.com/Archmonger/django-idom/tree/django-reactpy |
do you think we need the backends table here? |
Not from a technical standpoint, but it's free advertising that doesn't feel like advertising. The more click-throughs we get, the more we can snowball our overall popularity. Also, since our docs get auto-published, I think I might revert the problematic docs URLs in this PR |
I was planning to rehome the repo right after merging so perhaps we could leave the urls as is. |
It's very little extra effort to do a follow up PR to change URLs. We're already seeing some instances of confusion on the IDOM core docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with things as they are so approving. feel free to make those url changes though.
Good to merge? |
That last commit revealed some holes in my link checking workflow. Since the Also one more thing I want to revert is maintaining the |
Ok, just at me when it's ready and I'll merge/rehome. |
Since I didn't revert any Also, our readme logo solution doesn't play well with |
@rmorshea The docs expect to be built with a github.io page of We should move and rename the repo before merging, otherwise we'll end up with completely inaccessible and broken docs. This PR is otherwise ready to merge. |
LGTM! |
Description
Performs any changes needed to rename from
idom
toreactpy
.Checklist:
Please update this checklist as you complete each item: