Skip to content

synchronize JS and Py version requirements for IDOM #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

rmorshea
Copy link
Contributor

@rmorshea rmorshea commented Sep 9, 2021

The IDOM client and core libraries now have synchronized versions. To ensure they work correctly together we need to ensure the version requirements we use both are the same.

@rmorshea rmorshea requested a review from a team as a code owner September 9, 2021 05:44
@rmorshea rmorshea merged commit 1e575b0 into main Sep 9, 2021
@Archmonger
Copy link
Contributor

Are we going to configure an automated method of updating the JS and Py versions, or will it have to manually be bumped on each django-idom version release?

@rmorshea
Copy link
Contributor Author

rmorshea commented Sep 9, 2021

For now I've just been manually bumping the version for django-idom, idom-jupyter, idom-dash, etc.

Figuring out an automated way to do that would be nice though. Ideally, we could just have a chron job in GitHub actions that checks to see if there's a new version of IDOM available and then automatically creates a PR with the relevant changes if there is.

@rmorshea
Copy link
Contributor Author

rmorshea commented Sep 9, 2021

Actually it might be easier to generate an issue for each downstream repo when a new release of IDOM is published. Not quite as automated, but it's also less infra to maintain.

@rmorshea rmorshea deleted the fix-idom-py-js-versions branch September 9, 2021 06:27
@Archmonger
Copy link
Contributor

@rmorshea
Since current pypi installs can be potentially out of sync due to unpinned versions, I think it's a good idea to push out a pypi update to resolve this.

@rmorshea
Copy link
Contributor Author

I can't tonight, but I'll create a quick PR tomorrow to bump the version and then make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants