Skip to content

Fix IDOM preloader trying to parse commented out HTML templates #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2022
Merged

Fix IDOM preloader trying to parse commented out HTML templates #106

merged 6 commits into from
Oct 18, 2022

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Oct 16, 2022 •
edited
Loading

Description

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger requested a review from rmorshea October 16, 2022 22:30
@Archmonger Archmonger merged commit 9e48d7b into reactive-python:main Oct 18, 2022
@Archmonger Archmonger deleted the strip-html-comments branch October 18, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component regex tries to match commented out code Django Channels tests broken on Windows
2 participants
@Archmonger @rmorshea