Skip to content

Fix antipattern with IDOM_WEB_MODULE_PATH #37

Closed
@Archmonger

Description

@Archmonger

Old Behavior

Currently, we expect the user to add IDOM_WEB_MODULE_PATH within the urlpattern, however, this is an antipattern within the Django framework

New Behavior

Follow Django conventions and utilize standard path variables.

Implementation Details

Replace instructions to utilize IDOM_WEB_MODULE_PATH with path("idom/", include("django_idom.http.urls"))

Create django_idom.http.urls that contains a urlpatterns = [...]

Anywhere within django-idom where we need to determine the URL, we need to fetch it using django reverse("idom:web_modules")

This implementation also requires that we remove IDOM_BASE_URL as a variable.

Code of Conduct

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions