Improve documentation of lazy property on TabNavigatorConfig
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify `lazy` renders tabs upon first visit only
|
Deploy preview for react-navigation ready! Built with commit 747190f |
0xRAG
changed the title
lazy property on TabNavigatorConfig [#324]lazy property on TabNavigatorConfig
brentvatne
reviewed
Dec 23, 2018
| --- | ||
| id: version-3.x-tab-navigator | ||
| title: createTabNavigator | ||
| sidebar_label: createTabNavigator |
There was a problem hiding this comment.
createTabNavigator is gone in react-navigation@>=3.0, we have createBottomTabNavigator and createMaterialTopNavigator instead now :) so we can remove this doc
There was a problem hiding this comment.
Got it, makes sense that the file wasn't there already then!
|
aside from that one comment i left it looks good to me! let me know when that change is ready and i'll land it |
|
Thanks Brent! We should be good to go! |
|
thank you @rgilbert1! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added my changes to
bottom-tab-navigatorin the version 3.x docs, I hope that was the right thing to do 😬