Update NavigationService example for v3 #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation ready! Built with commit d9c0b50 |
|
Looks like the answer's yes, seeing as the 3.x docs in the deploy preview don't have my changes. Updating shortly. :) |
vonovak
reviewed
Dec 5, 2018
website/versioned_docs/version-3.x/navigating-without-navigation-prop.md
Show resolved
Hide resolved
I am trying to follow these two doc pages in conjunction: - https://reactnavigation.org/docs/en/app-containers.html - https://reactnavigation.org/docs/en/navigating-without-navigation-prop.html Though the "Navigating without the navigation prop" seems out of date since the introduction of explicit app containers in v3, the **App Containers** page indicates that I can get a ref on the _container_ that functions just like a navigator. After a couple of false starts, I stumbled upon what seems to be the correct setup, but it would have been helpful to start from a working example without having to infer the correct combination. My minimal working example: https://snack.expo.io/@brettdh/navigationservice-and-createappcontainer Possibly related: react-navigation/react-navigation#5252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to follow these two doc pages in conjunction:
Though the "Navigating without the navigation prop" seems out of date since the introduction of explicit app containers in v3, the App Containers page indicates that I can get a ref on the container that functions just like a navigator. After a couple of false starts, I stumbled upon what seems to be the correct setup, but it would have been helpful to start from a working example without having to infer the correct combination.
My minimal working example:
https://snack.expo.io/@brettdh/navigationservice-and-createappcontainer
Possibly related: react-navigation/react-navigation#5252
Make sure to add your changes to versioned docs
I didn't see a
website/versioned_docs/version-3.x/navigating-without-navigation-prop.mdfile, and I'm not sure if I should be creating one there; please let me know what's correct. Thanks!