fixes the re-render warning for using useIsFocused #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It re-renders the direct component that contains this hook, but it was mentioned that it re-renders the screen.
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
satya164
requested changes
Jan 12, 2024
Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It re-renders the direct component that contains this hook, but it was mentioned that it re-renders the screen.
READ ME PLEASE
Thanks for opening a PR!
The docs cover several versions of
react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").Please make sure that the edit you're making in
docs/file-you-edited.mdis also included in the file for the correct version, eg./versioned_docs/version-3.x/file-you-edited.mdfor version 3. If such file doesn't exist, please create it. 👍