Skip to content

chore: add kotlin version of code #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

dcangulo
Copy link
Contributor

@dcangulo dcangulo commented Dec 7, 2023

Kotlin is now used in the template starting at 0.73. This PR adds Kotlin examples together with Java.

Currently, Java is opened by default while Kotlin is collapsed, not sure if I should swap, just let me know.

Source: https://github.com/software-mansion/react-native-screens#android

Screenshot 2023-12-07 at 18 44 16 Screenshot 2023-12-07 at 18 44 24

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit 93cfc9e
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/6571a38a65323c00089c03ba
😎 Deploy Preview https://deploy-preview-1290--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit 7b5c302
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/6571c90bb0e13f0008598a58
😎 Deploy Preview https://deploy-preview-1290--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think it maybe better to use tabs here
https://docusaurus.io/docs/markdown-features/tabs

And I'd make Kotlin the default since it's the default in React Native now.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164 satya164 merged commit c8bb6ca into react-navigation:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants