fix: renamed createStackNavigator to createNativeStackNavigator #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-navigation-docs ready! 🔨 Explore the source changes: 9b51a2a 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-docs/deploys/613a75815576a800080a6435 😎 Browse the preview: https://deploy-preview-1053--react-navigation-docs.netlify.app |
arcollector
changed the title
arcollector
force-pushed
the
patch-1
branch
2 times, most recently
from
d68ed50 to
7696e46
Compare
kacperkapusciak
requested changes
Sep 9, 2021
|
|
||
| const Stack = createStackNavigator(); | ||
| const NativeStack = createNativeStackNavigator(); |
There was a problem hiding this comment.
Suggested change
| const NativeStack = createNativeStackNavigator(); | |
| const Stack = createNativeStackNavigator(); |
native-stack is also a stack, no need to overdo this.
|
|
||
| function MyStack() { | ||
| function MyNativeStack() { |
There was a problem hiding this comment.
Suggested change
| function MyNativeStack() { | |
| function MyStack() { |
burakgormek
reviewed
Sep 9, 2021
|
|
||
| function MyStack() { | ||
| return ( | ||
| <Stack.Navigator | ||
| <NativeStack.Navigator |
There was a problem hiding this comment.
You forgot to change here and also Screens
Documentation was refering to `createStackNavigator` function instead of `createNativeStackNavigator`
kacperkapusciak
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation was refering to
createStackNavigatorfunction instead ofcreateNativeStackNavigator