Skip to content

docs: Missing backtick on headerMode is moved to options #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

amandeepmittal
Copy link
Contributor

@amandeepmittal amandeepmittal commented May 29, 2021

In the Markdown file for the document, there is a missing backtick on a section heading.

Previously:

`headerMode is moved to options.

This PR resolves:

`headerMode` is moved to options.

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. 👍

@netlify
Copy link

netlify bot commented May 29, 2021

✔️ Deploy Preview for react-navigation-docs ready!

🔨 Explore the source changes: 4a090f5

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-docs/deploys/60b22a3e1af8290008525f3d

😎 Browse the preview: https://deploy-preview-1002--react-navigation-docs.netlify.app

Copy link
Member

@eriveltonelias eriveltonelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@eriveltonelias eriveltonelias merged commit e267fca into react-navigation:main Jun 5, 2021
@amandeepmittal amandeepmittal deleted the patch-1 branch June 6, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants