CallUUID changes after `startCall`

[homersimpsons]

Bug report

• I've checked the example to reproduce the issue.

• Reproduced on:

• Android

• iOS

Description

On android the callUuid set with startCall is not kept afterward.

Steps to Reproduce

With a snippet like this:

const callUuid = 'ccb3991f-9606-40d7-ba98-a021a0ecb4a0';

RNCallKeep.addEventListener('didReceiveStartCallAction', ({ callUUID }) => {
  console.log('didReceiveStartCallAction', callUUID, callUuid)
})
RNCallKeep.startCall(callUuid, '+15555555555', 'John Doe', 'generic', false)

You can easily notice something like the following in the logs:

didReceiveStartCallAction 1444793b-ec42-4cf0-a1f2-7ab9693a9793 ccb3991f-9606-40d7-ba98-a021a0ecb4a0

Versions

- Callkeep: 8fef467243adc52dc85e732f806472f3a8ebd4a8
- React Native: 0.65.1
- iOS: ~
- Android: ~
- Phone model: ~

Logs

11-08 11:29:15.273 18234 20342 D RNCallKeep: [RNCallKeepModule] startCall called, uuid: ccb3991f-9606-40d7-ba98-a021a0ecb4a0, number: +15555555555, callerName: John Doe
11-08 11:29:15.275 18234 20342 D RNCallKeep: [RNCallKeepModule] startCall, uuid: ccb3991f-9606-40d7-ba98-a021a0ecb4a0
11-08 11:29:15.597 18234 18234 D RNCallKeep: [VoiceConnectionService] Constructor
11-08 11:29:15.636 18234 18234 D RNCallKeep: [VoiceConnectionService] onCreateOutgoingConnection, uuid:1444793b-ec42-4cf0-a1f2-7ab9693a9793
11-08 11:29:15.637 18234 18234 D RNCallKeep: [VoiceConnectionService] makeOutgoingCall, uuid:1444793b-ec42-4cf0-a1f2-7ab9693a9793, number: +15555555555, displayName:John Doe
11-08 11:29:15.637 18234 18234 D RNCallKeep: [VoiceConnectionService] onCreateOutgoingConnection: disabling multi calls
11-08 11:29:15.637 18234 18234 D RNCallKeep: [VoiceConnectionService] createConnection, callerNumber:tel:%2B15555555555
11-08 11:29:15.638 18234 18234 D RNCallKeep: [VoiceConnectionService] PhoneAccount is not SELF_MANAGED, so connection won't be either
11-08 11:29:15.638 18234 18234 D RNCallKeep: [VoiceConnection] onStateChanged called, state : 0
11-08 11:29:15.638 18234 18234 D RNCallKeep: [VoiceConnection] onStateChanged called, state : 3
11-08 11:29:15.638 18234 18234 D RNCallKeep: [VoiceConnectionService] startForegroundService
11-08 11:29:15.640 18234 18234 D RNCallKeep: [VoiceConnectionService] Starting foreground service
11-08 11:29:15.643 18234 18234 D RNCallKeep: [VoiceConnectionService] onCreateOutgoingConnection: initializing connection on Samsung device
11-08 11:29:15.643 18234 18234 D RNCallKeep: [VoiceConnection] onStateChanged called, state : 1
11-08 11:29:15.643 18234 18234 D RNCallKeep: [VoiceConnectionService] sendCallRequestToActivity, action:ACTION_ONGOING_CALL
11-08 11:29:15.643 18234 18234 D RNCallKeep: [VoiceConnectionService] sendCallRequestToActivity, action:ACTION_AUDIO_SESSION
11-08 11:29:15.643 18234 18234 D RNCallKeep: [VoiceConnectionService] onCreateOutgoingConnection: done
11-08 11:29:15.646 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_ONGOING_CALL
11-08 11:29:15.646 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepDidReceiveStartCallAction, bound: true, hasListeners: true args : { NativeMap: {"name":"John Doe","callUUID":"1444793b-ec42-4cf0-a1f2-7ab9693a9793","handle":"+15555555555"} }
11-08 11:29:15.655 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_AUDIO_SESSION
11-08 11:29:15.655 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepDidActivateAudioSession, bound: true, hasListeners: true args : null
11-08 11:29:15.729 18234 18234 D RNCallKeep: [VoiceConnection] onCallAudioStateChanged muted :false
11-08 11:29:15.729 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_DID_CHANGE_AUDIO_ROUTE
11-08 11:29:15.729 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepDidChangeAudioRoute, bound: true, hasListeners: true args : { NativeMap: {"output":"SPEAKER","callUUID":"1444793b-ec42-4cf0-a1f2-7ab9693a9793","handle":"%2B15555555555"} }
11-08 11:29:15.739 18234 18234 D RNCallKeep: [VoiceConnection] onCallAudioStateChanged muted :false
11-08 11:29:15.740 18234 18234 D RNCallKeep: [VoiceConnection] onCallAudioStateChanged muted :false
11-08 11:29:15.740 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_DID_CHANGE_AUDIO_ROUTE
11-08 11:29:15.742 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepDidChangeAudioRoute, bound: true, hasListeners: true args : { NativeMap: {"output":"SPEAKER","callUUID":"1444793b-ec42-4cf0-a1f2-7ab9693a9793","handle":"%2B15555555555"} }
11-08 11:29:15.743 18234 18234 D RNCallKeep: [VoiceConnection] onCallAudioStateChanged muted :false
11-08 11:29:15.743 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_DID_CHANGE_AUDIO_ROUTE
11-08 11:29:15.743 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepDidChangeAudioRoute, bound: true, hasListeners: true args : { NativeMap: {"output":"SPEAKER","callUUID":"1444793b-ec42-4cf0-a1f2-7ab9693a9793","handle":"%2B15555555555"} }
11-08 11:29:15.743 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_DID_CHANGE_AUDIO_ROUTE
11-08 11:29:15.744 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepDidChangeAudioRoute, bound: true, hasListeners: true args : { NativeMap: {"output":"SPEAKER","callUUID":"1444793b-ec42-4cf0-a1f2-7ab9693a9793","handle":"%2B15555555555"} }
11-08 11:29:22.151 18234 18234 D RNCallKeep: [VoiceConnection] onStateChanged called, state : 6
11-08 11:29:22.151 18234 18234 D RNCallKeep: [VoiceConnection] onDisconnect executed
11-08 11:29:22.151 18234 18234 D RNCallKeep: [VoiceConnectionService] deinitConnection:1444793b-ec42-4cf0-a1f2-7ab9693a9793
11-08 11:29:22.151 18234 18234 D RNCallKeep: [VoiceConnectionService] stopForegroundService
11-08 11:29:22.166 18234 18234 D RNCallKeep: [RNCallKeepModule][onReceive] :ACTION_END_CALL
11-08 11:29:22.166 18234 18234 V RNCallKeep: [RNCallKeepModule] sendEventToJS, eventName: RNCallKeepPerformEndCallAction, bound: true, hasListeners: true args : { NativeMap: {"callUUID":"1444793b-ec42-4cf0-a1f2-7ab9693a9793"} }

Diagnostic

I did a small dig in the project and I guess the issue comes from this line:

react-native-callkeep/android/src/main/java/io/wazo/callkeep/VoiceConnectionService.java

Line 218 in 4b1fa98

String uuid = UUID.randomUUID().toString();

[saif-o99]

i replaced the line you pointed out
String uuid = UUID.randomUUID().toString();

with
Bundle extras = request.getExtras();
String callUUID = extras.getString(EXTRA_CALL_UUID);

and it seems the call working but i don't why would they generate a new UUID on start call