-
Notifications
You must be signed in to change notification settings - Fork 475
chore: bump react-native to 0.68 #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@krizzu: Would you mind taking a look at Android? I got build errors I'm not sure how to proceed on. I'll take a look at Windows in the meantime. |
@tido64 so the problem is that test-app has bumped to Kotlin 1.7. So we have to solutions:
With first one, it's hard to assess how much of impact it would be on project that'd depend on AsyncStorage, which are still on lower version of Kotlin. It'd be good to test this KSP integration with lower Kt version to see if it's still compatible. Second one has drawback of Room requiring compilation/target sdk of 32. That means developer should migrate in project to those version and check compatibility of the rest of the app. I'd be in favor on going with first approach, but would have to test the scenario first. |
5587eb5
to
b816642
Compare
2b38af4
to
94078f7
Compare
a238316
to
e7a1b82
Compare
e7a1b82
to
1ffa26e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's not block it 👌
🎉 This PR is included in version 1.17.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Bumps react-native to 0.68.
Test Plan
Make sure that
yarn start:*
works: