Skip to content

chore: bump react-native to 0.68 #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 21, 2022

Summary

Bumps react-native to 0.68.

Test Plan

Make sure that yarn start:* works:

  • Android
  • iOS
  • macOS
  • Windows

@tido64
Copy link
Member Author

tido64 commented Jul 21, 2022

@krizzu: Would you mind taking a look at Android? I got build errors I'm not sure how to proceed on. I'll take a look at Windows in the meantime.

@krizzu
Copy link
Member

krizzu commented Jul 21, 2022

@tido64 so the problem is that test-app has bumped to Kotlin 1.7. So we have to solutions:

  • Use KSP instead of KAPT for annotation processing. This requires few steps, like described in this SO post.
  • Update Room to 2.5.0-alpha02, which has Kotlin 1.7 compatibility

With first one, it's hard to assess how much of impact it would be on project that'd depend on AsyncStorage, which are still on lower version of Kotlin. It'd be good to test this KSP integration with lower Kt version to see if it's still compatible.

Second one has drawback of Room requiring compilation/target sdk of 32. That means developer should migrate in project to those version and check compatibility of the rest of the app.

I'd be in favor on going with first approach, but would have to test the scenario first.

@tido64 tido64 force-pushed the tido/bump-react-native-0.68 branch from 5587eb5 to b816642 Compare July 22, 2022 14:35
@tido64 tido64 force-pushed the tido/bump-react-native-0.68 branch from 2b38af4 to 94078f7 Compare August 16, 2022 08:11
@tido64
Copy link
Member Author

tido64 commented Aug 16, 2022

@tido64 so the problem is that test-app has bumped to Kotlin 1.7

I've added a flag to the test app so we can set our own Kotlin version and opened #832 to track support of 1.7. Everything should be building again now.

@tido64 tido64 force-pushed the tido/bump-react-native-0.68 branch 2 times, most recently from a238316 to e7a1b82 Compare August 24, 2022 14:27
@tido64 tido64 force-pushed the tido/bump-react-native-0.68 branch from e7a1b82 to 1ffa26e Compare August 30, 2022 15:36
@tido64 tido64 enabled auto-merge (squash) September 6, 2022 09:46
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's not block it 👌

@tido64 tido64 merged commit 3ff863f into master Sep 6, 2022
@tido64 tido64 deleted the tido/bump-react-native-0.68 branch September 6, 2022 12:33
@krizzu
Copy link
Member

krizzu commented Nov 11, 2022

🎉 This PR is included in version 1.17.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants