Skip to content

chore: address potential security vulnerabilities #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

chore: address potential security vulnerabilities #752

merged 2 commits into from
Feb 17, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Feb 16, 2022

@tido64 tido64 requested a review from krizzu February 16, 2022 13:51
krizzu
krizzu approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is windows failing due to the dependency upgrade?

@tido64
Copy link
Member Author

tido64 commented Feb 17, 2022

Is windows failing due to the dependency upgrade?

It looks like the Windows VMs got updated, and now we're missing an SDK. I'll try to figure out how to get the specific version installed later today.

@tido64
Copy link
Member Author

tido64 commented Feb 17, 2022

I had to downgrade the Windows VMs we were using: #754

Once that lands, I'll rebase the dependency PRs.

@tido64
Copy link
Member Author

tido64 commented Feb 17, 2022

I had to downgrade the Windows VMs we were using: #754

Once that lands, I'll rebase the dependency PRs.

Or I can downgrade the Windows VM here since I'm having issues with CircleCI on the other one.

@tido64 tido64 merged commit 3dac112 into master Feb 17, 2022
@tido64 tido64 deleted the tido/address-security branch February 17, 2022 16:37
@krizzu
Copy link
Member

krizzu commented Mar 15, 2022

🎉 This PR is included in version 1.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @krizzu