Skip to content

fix: declare support for react-native 0.65 #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix: declare support for react-native 0.65 #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"merge-options": "^3.0.4"
},
"peerDependencies": {
"react-native": "^0.60.6 || ^0.61.5 || ^0.62.2 || ^0.63.2 || ^0.64.0 || 1000.0.0"
"react-native": "^0.0.0-0 || ^0.60.6 || ^0.61.5 || ^0.62.2 || ^0.63.2 || ^0.64.0 || ^0.65.0 || 1000.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never fully understood why libraries need to be so specific about their support. From my understanding, react-native-async-storage/async-storage supports React Native 0.60.6 and above. So, why not simply use "react-native": ">=0.60.6" here instead?

Of course, we don't know whether it will support 0.66 and beyond yet, but I guess it's weighing the pros and cons of having to update the library every couple of months by adding a new version, versus being optimistic considering that there are only very few dependencies that actually could break. I would rather accept the risk of things breaking in the future due to an unexpected change in React Native, than having to rely on the original author of a library continuously keeping it up to date.

Or in other words (in a dramatic voice): It's already been three days, why hasn't this been merged yet? Whyyyy? Whyyyyyyy?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls approve and marge it

},
"devDependencies": {
"@babel/core": "^7.8.4",
Expand Down Expand Up @@ -94,14 +94,6 @@
"react-test-renderer": "16.13.1",
"semantic-release": "^17.2.1"
},
"resolutions": {
"//": "We must use a single version of Metro otherwise bundling will break on Windows",
"metro": "^0.59.0",
"metro-config": "^0.59.0",
"metro-core": "^0.59.0",
"metro-react-native-babel-transformer": "^0.59.0",
"metro-resolver": "^0.59.0"
},
"jest": {
"preset": "react-native",
"setupFiles": [
Expand Down