Skip to content

docs: Update iOS Linking information #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2019
Merged

docs: Update iOS Linking information #61

merged 6 commits into from
Apr 10, 2019

Conversation

clucasalcantara
Copy link
Contributor

Summary:

After the discussions on issue #56 I've noticed that we have missing information about iOS Linking and almost none about the manual linking process, this PR aims to provide this missing info.

Test Plan:

No needed, only docs changes.

docs: Update iOS manual linkining info
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clucasalcantara, thanks for your input!

I've left small comment, after you address it, it'd be ready to merge.

thanks.

chore: Update iOS manual link infor
@clucasalcantara
Copy link
Contributor Author

Hey @krizzu :) Noted! I've made a few changes, please take a look :)

@krizzu
Copy link
Member

krizzu commented Apr 8, 2019

Hey @clucasalcantara,

Can you split pod and .xcodeproj linking into sections please?

thanks.

chore: Split packaging and pod into sections
@clucasalcantara
Copy link
Contributor Author

Hey @clucasalcantara,

Can you split pod and .xcodeproj linking into sections please?

thanks.

Sorry @krizzu , didn't noticed that :) I've split into step one and step two.

@krizzu
Copy link
Member

krizzu commented Apr 8, 2019

Hey @clucasalcantara

I would not call them step one/two as this is misleading. Those are completely separate steps, not requiring one another.

You choose one of the way to link a library, otherwise you end up with same module, linked twice.

thanks

@krizzu krizzu added the Docs label Apr 8, 2019
@clucasalcantara
Copy link
Contributor Author

Hey @krizzu

XCode Mode and Pod Mode sounds better?

@krizzu
Copy link
Member

krizzu commented Apr 8, 2019

Hi @clucasalcantara

What about Using 'Pods' and Project linking ?

@clucasalcantara
Copy link
Contributor Author

Even better, on it

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clucasalcantara

Thank you so far for this. I've left two comments, please check them out. After that, we can merge it 💪

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot 🚀

@krizzu krizzu merged commit e2a58a4 into react-native-async-storage:master Apr 10, 2019
@krizzu
Copy link
Member

krizzu commented Apr 10, 2019

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants