Migrate Expo storage directory on iOS #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
reviewed
Mar 28, 2021
ios/RNCAsyncStorage.m
Outdated
Comment on lines
440
to
444
| // Then migrate what's in "Documents/.../RCTAsyncLocalStorage_V1" to "Application | ||
| // Support/[bundleID]/RCTAsyncLocalStorage_V1" | ||
| RCTStorageDirectoryMigrationCheck(RCTCreateStorageDirectoryPath_deprecated(RCTStorageDirectory), | ||
| RCTCreateStorageDirectoryPath(RCTStorageDirectory), | ||
| NO); |
There was a problem hiding this comment.
This migration needs to be outside of the if statement - it's not related to Expo, but normal RN projects. If someone upgrades from pre 1.8.0 version, the migration to Application Support won't kick in
There was a problem hiding this comment.
addressed this feedback, did manual testing again and works as expected
|
Android CI failure is unrelated |
|
Nice one @brentvatne 👏 |
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves an issue users encountered with the following process:
Something that I noticed while implementing this was that it is theoretically possible (although extremely unlikely) that a user would have both an old storage directory and an Expo storage directory ("RNCAsyncLocalStorage_V1" and "RCTAsyncLocalStorage"). To handle this case, I added
RCTGetStoragePathForMigration.The Android side of this migration is handled in #559
Test Plan
expo initwith managed Typescript template,expo install @react-native-async-storage/async-storage, then added that code to App.tsx).expo build:ios -t simulator(it takes about 2 minutes to build, you can access the binary here for the next ~28 days).expo eject, applied the patch from this PR to my local copy ofRNCAsyncStorage.m, then built the project and ran it on the same simulator as the previous step.Here's a video quick run through the above test plan, skipping the steps that could be done in advance:
post.mp4
(I added !! after the count to make it especially clear that this is a different build)